[ENG-7839] [ENG-7766] Add celery task to update Datacite metadata + Use new GV API endpoint to retrieve node's verified links + Update unit tests #11130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vlad0n20
changed the title
Vlad0n20
force-pushed
the
feature/ENG-7839
branch
3 times, most recently
from
d28e8c9 to
d05c9a2
Compare
cslzchen
requested changes
May 14, 2025
cslzchen
requested changes
May 14, 2025
There was a problem hiding this comment.
Review update:
First, let's make the use of the mock consistent:
- No need to define the fixture outside
conftest.py - Always use the
@pytest.mark.usefixtures()(instead of using@pytest.fixture(autouse=True)or adding an extra argument).
Second, take a look at all the metadata file changes, as I mentioned in the comment.
osf_tests/metadata/expected_metadata_files/project_basic.turtle
Outdated
Show resolved
Hide resolved
…test.mark.usefixtures(). Also replace pass the mock as arguments to decorator style
Vlad0n20
force-pushed
the
feature/ENG-7839
branch
from
07f409e to
89b5a3d
Compare
cslzchen
requested changes
May 15, 2025
osf_tests/metadata/expected_metadata_files/registration_supplement.turtle
Show resolved
Hide resolved
cslzchen
approved these changes
May 16, 2025
There was a problem hiding this comment.
Looks good and thanks for the awesome work @Vlad0n20 and great support @opaduchak. I will take care of the rest nitpicking stuff before merge.
cslzchen
force-pushed
the
feature/ENG-7839
branch
from
556304a to
2190a32
Compare
cslzchen
changed the title
cslzchen
merged commit 1686ef8
into
CenterForOpenScience:feature/verified-resource-linking
6 checks passed
cslzchen
added a commit
to cslzchen/osf.io
that referenced
this pull request
May 19, 2025
…NG-7839 [ENG-7839] [ENG-7766] Add celery task to update Datacite metadata + Use new GV API endpoint to retrieve node's verified links + Update unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
See diff
QA Notes
N/A
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-7839
https://openscience.atlassian.net/browse/ENG-7766